asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Feed Adaptor and RecordReader Clean
Date Mon, 17 Apr 2017 04:48:27 GMT
Till Westmann has posted comments on this change.

Change subject: Feed Adaptor and RecordReader Clean
......................................................................


Patch Set 10:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1535/10//COMMIT_MSG
Commit Message:

PS10, Line 10: serivce
s/serivce/service/


https://asterix-gerrit.ics.uci.edu/#/c/1535/10/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java:

PS10, Line 40: quotedReader
I think that having the LineRecordReader and QuotedLineRecordReader as two different classes
looks a bit cleaner.
It also seems that there's a potential to share code between the 2 hasNext() methods that
could address SonarQube's deep nesting complaints in a reasonable way.
I'm wondering if StreamRecordReaderProvider.getRecordReaderClazz could be used to address
the construction of different readers based on the configuration a factory method.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1535
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699657ddd8408fd00bcbd7df57b6610ef3692a1a
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message