asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Update the Feed Tutorial
Date Tue, 04 Apr 2017 22:02:08 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Update the Feed Tutorial
......................................................................


Patch Set 3:

(19 comments)

Stopped at the a vs an comment. please, revisit the writing and ensure that it is grammatically
correct

https://asterix-gerrit.ics.uci.edu/#/c/1533/2/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md:

PS2, Line 248: disconnect feed my_feed from dataset RssDataset;
add test case


https://asterix-gerrit.ics.uci.edu/#/c/1533/3/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md:

PS3, Line 64: definition
definitions


PS3, Line 90:  with Twitter
remove" with Twitter"


PS3, Line 91:  an associated
associated


PS3, Line 92: credential
credentials


PS3, Line 92: includes
include


PS3, Line 99: adaptor
let's unify all to be adapter rather than adaptor?


PS3, Line 101: adaptor.
tor -> ter


PS3, Line 105: adaptor
er


PS3, Line 117: are provided valid values.
are valid. remove the rest?


PS3, Line 119: our
the


PS3, Line 120:  AsterixDB
the instance


PS3, Line 122: (which we shall revisit later).
remove


PS3, Line 124: adaptor
er


PS3, Line 156: different
multiple


PS3, Line 190: Adaptors
ers


PS3, Line 192: adapters
yes


PS3, Line 224: an RSS endpoint or a RSS 
an then a??????
The correct use IMO is an.


PS3, Line 331: Ingesting
tion


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1533
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia18d0b2e3f483332058d9739350643e7f8773433
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message