asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Ensure Metadata locks are acquired for SQL++ queries
Date Sun, 02 Apr 2017 06:17:55 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Ensure Metadata locks are acquired for SQL++ queries
......................................................................


Patch Set 14:

> LGTM.  I couldn't think of a deadlock case so far ( (A) no DDL that
 > write locks two instances of following things, dataverses,
 > datasets, functions, nodegroups, feeds, feeds-policy,
 > compaction-policy, datatypes, extensions -- so at most 1 write lock
 > for a DDL,  (B) the (only one) write lock is the last one to
 > acquire), but I give Till a chance to review it by +1:-)

Exactly, the write lock is always the last.
We assume that no additional read locks will be acquired after that for those statements (and
they shouldn't), otherwise, there is a bug.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1642
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message