Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC2A0200C46 for ; Wed, 29 Mar 2017 17:14:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CA717160B8A; Wed, 29 Mar 2017 15:14:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1CADD160B7C for ; Wed, 29 Mar 2017 17:14:57 +0200 (CEST) Received: (qmail 36183 invoked by uid 500); 29 Mar 2017 15:14:57 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 36174 invoked by uid 99); 29 Mar 2017 15:14:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Mar 2017 15:14:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EE25AC002B for ; Wed, 29 Mar 2017 15:14:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id k9GlWRCHBW6n for ; Wed, 29 Mar 2017 15:14:56 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8F8415F4A7 for ; Wed, 29 Mar 2017 15:14:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 004162420A2; Wed, 29 Mar 2017 08:14:55 -0700 (PDT) Date: Wed, 29 Mar 2017 08:14:54 -0700 From: "Till Westmann (Code Review)" To: Yingyi Bu CC: Jenkins , Michael Blow Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Raise exceptions for invalid query parameters. X-Gerrit-Change-Id: I7dfc7fb76d76a3af243b0db674ee730aa1748df3 X-Gerrit-ChangeURL: X-Gerrit-Commit: b0b8227a0c31c69897aa3483018bcf655e9be094 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170329151455.004162420A2@unhygienix.ics.uci.edu> archived-at: Wed, 29 Mar 2017 15:14:59 -0000 Till Westmann has posted comments on this change. Change subject: Raise exceptions for invalid query parameters. ...................................................................... Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1627/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: PS1, Line 463: getFrameLimit make the method static? https://asterix-gerrit.ics.uci.edu/#/c/1627/1/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: PS1, Line 83: Query parameter %1$s is invalid s/Query parameter %1$s is invalid/Invalid query parameter %1$s/ PS1, Line 83: it should be large than or equal to %2$s bytes s/it should be large than or equal to %2$s bytes/value has to be greater than or equal to %2$s bytes/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1627 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dfc7fb76d76a3af243b0db674ee730aa1748df3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes