asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Raise exceptions for invalid query parameters.
Date Wed, 29 Mar 2017 15:14:54 GMT
Till Westmann has posted comments on this change.

Change subject: Raise exceptions for invalid query parameters.
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1627/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

PS1, Line 463: getFrameLimit
make the method static?


https://asterix-gerrit.ics.uci.edu/#/c/1627/1/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS1, Line 83: Query parameter %1$s is invalid
s/Query parameter %1$s is invalid/Invalid query parameter %1$s/


PS1, Line 83: it should be large than or equal to %2$s bytes
s/it should be large than or equal to %2$s bytes/value has to be greater than or equal to
%2$s bytes/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1627
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfc7fb76d76a3af243b0db674ee730aa1748df3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message