asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Index-Only Plan Patch Set 4: modifies SearchOpCallBack
Date Tue, 28 Mar 2017 01:15:25 GMT
Yingyi Bu has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: modifies SearchOpCallBack
......................................................................


Patch Set 5:

(2 comments)

Do we really need cancelProceed() since all implementations are empty?  
Are there potentially cases that we need non-empty cancelProceed()?

The differentiation of cancelReconcile() and cancelProceed() make index cursor code more complex,
while previously it's clearly documented that cancel() is only called up on reconcile().

https://asterix-gerrit.ics.uci.edu/#/c/1597/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java:

PS5, Line 99: if
merge the if condition with !resultOfSearchCallBackProceed?  The two else branches are doing
the same thing:  searchCallback.reconcile(checkElement.getTuple());


https://asterix-gerrit.ics.uci.edu/#/c/1597/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java:

PS5, Line 181: ;
Why proceed/reconcile is removed from the next method?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1597
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16992b3bdc1bfc739417d11366d6bafc59294a0b
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message