asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Send Bad-request response on failure of decoding query string
Date Tue, 21 Mar 2017 23:20:51 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Send Bad-request response on failure of decoding query string
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1602/1/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java:

PS1, Line 88:             LOGGER.log(Level.WARNING, "Failure Decoding Request", e);
            :             respond(ctx, request, HttpResponseStatus.BAD_REQUEST);
            :             return;
> Should we have a single method (e.g. respondWithStatus) that takes a status
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1602
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa000e469392a5e4b079b331472edd0dc4f65a4
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message