asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1841: Fix Inverted Index Drop Operator
Date Tue, 21 Mar 2017 19:12:57 GMT
Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1841: Fix Inverted Index Drop Operator
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1600/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/IndexUtil.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/IndexUtil.java:

PS1, Line 102: Collections.singletonList
> Would it work to use Java's Collections.singletonList here?
Yup. Both Collections.singletonList and Arrays.asList should be fine. I just used the same
code in QueryTranslator which is using guava. Changed to Collections.singletonList.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1600
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0f52770fd791ab9293c661de810c0b3b9ba8fb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message