asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add Active Partition Event Message
Date Mon, 20 Mar 2017 04:25:38 GMT
Till Westmann has posted comments on this change.

Change subject: Add Active Partition Event Message
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1596/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java:

PS1, Line 34: EVENT
This name is confusing. The byte-sized member is called "event" and this is called ACTIVE_RUNTIME_EVENT.
Could this be a GENERIC_EVENT or a GENERIC_NOTIFICATION, or ...


https://asterix-gerrit.ics.uci.edu/#/c/1596/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS1, Line 713: configureNodegroupForDataset
s/dataverse/dataverseName/ to be consistent?

Just if there's a new patch set for another reason.


https://asterix-gerrit.ics.uci.edu/#/c/1596/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java:

PS2, Line 83: tasetName, new 
I think that there was a misunderstanding. I think that Mike's idea was to use Map.computeIfAbsent
[1] for the creation of the object if it's not there.

[1] https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#computeIfAbsent-K-java.util.function.Function-


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1596
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b4629752e912614927b816d4ce3422ac89c5426
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message