asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Shutdown ActiveManager Before Killing Thread Executors
Date Sat, 18 Mar 2017 21:22:44 GMT
Michael Blow has posted comments on this change.

Change subject: Shutdown ActiveManager Before Killing Thread Executors
......................................................................


Patch Set 6:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1594/6/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java:

PS6, Line 127: if (runtimes.remove(runtimeId) != null) {
             :                         runtime.stop();
             :                     } else {
             :                         LOGGER.info("Not stopping already stopped runtime "
+ runtimeId);
             :                     }
> seems like stopping runtime can be refactored into a method that gets calle
Done


https://asterix-gerrit.ics.uci.edu/#/c/1594/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java:

PS6, Line 153: preStop()
> Till doesn't like the name preStop() in the interface
? thanks for sharing...


https://asterix-gerrit.ics.uci.edu/#/c/1594/6/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplication.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplication.java:

PS6, Line 25: //NOSONAR
> you gave me this comment before. Do we really want to supress sonar warning
it matches the contract of the other lifecycle methods in IApplication


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1594
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45e83b0378198f80297fd2741969507741914dea
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message