asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Shutdown ActiveManager Before Killing Thread Executors
Date Fri, 17 Mar 2017 23:03:48 GMT
Michael Blow has posted comments on this change.

Change subject: Shutdown ActiveManager Before Killing Thread Executors
......................................................................


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1594/4/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java:

PS4, Line 40: ThreadExecutor
> Why move to ThreadExecutor here if all we need is an Executor?
We need ThreadExecutor now as we need to get Futures back from the submissions...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1594
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45e83b0378198f80297fd2741969507741914dea
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message