asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add documentation for query parameters.
Date Fri, 17 Mar 2017 14:17:27 GMT
Michael Blow has posted comments on this change.

Change subject: Add documentation for query parameters.
......................................................................


Patch Set 6:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1586/6/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameter.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameter.md:

PS6, Line 43: suffix
I think we should specify "binary unit suffix" or "binary unit symbols" to explicitly indicate
that these are base-1024 and not base-1000.


PS6, Line 44: "bytes" is the default suffix
B is the default suffix.  Given that B is the default suffix, maybe we could replace "64-bit
integer as bytes, or a 64-bit integer value with KB/MB/GB suffix" with just "64-bit integer
value with B/KB/MB/GB suffix"


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1586
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80dcd668bea3b2b3fff0c0778548ffad63505d99
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message