asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix transaction logs and optimize upserts
Date Sun, 12 Mar 2017 20:14:22 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Fix transaction logs and optimize upserts
......................................................................


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1554/7/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/ophelpers/IndexOperation.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/ophelpers/IndexOperation.java:

PS7, Line 36:     public static final byte INSERT_BYTE = 0x01;
            :     public static final byte DELETE_BYTE = 0x02;
            :     public static final byte UPSERT_BYTE = 0x03;
            : 
            :     public static final byte getLogRecordOpByte(IndexOperation op) {
            :         switch (op) {
            :             case DELETE:
            :                 return DELETE_BYTE;
            :             case INSERT:
            :                 return INSERT_BYTE;
            :             case UPSERT:
            :                 return UPSERT_BYTE;
            :             default:
            :                 throw new IllegalArgumentException("Op");
            :         }
            :     }
            : }
Will move this to asterixdb since hyracks shouldn't be aware of logs


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1554
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5296267033cd7debe76894c864c6411f761d83
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message