asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Remove Usages Of Jps To Enable Running With JRE
Date Fri, 10 Mar 2017 00:34:03 GMT
Till Westmann has posted comments on this change.

Change subject: Remove Usages Of Jps To Enable Running With JRE
......................................................................


Patch Set 2:

(12 comments)

Looks generally good. I'd just prefer if we just used awk instead of a combination of awk
and grep, if awk is sufficient.

https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/asterix/stopcc.sh
File asterixdb/asterix-app/scripts/asterix/stopcc.sh:

PS2, Line 20: grep
Just stick to awk here

    awk '/java.*CCDriver/ {print $2}'

?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/asterix/stopnc.sh
File asterixdb/asterix-app/scripts/asterix/stopnc.sh:

PS2, Line 20: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/idefix/stopallncs.sh
File asterixdb/asterix-app/scripts/idefix/stopallncs.sh:

PS2, Line 20: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/idefix/stopcc.sh
File asterixdb/asterix-app/scripts/idefix/stopcc.sh:

PS2, Line 20: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/rainbow/stopcc.sh
File asterixdb/asterix-app/scripts/rainbow/stopcc.sh:

PS2, Line 20: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-app/scripts/rainbow/stopnc.sh
File asterixdb/asterix-app/scripts/rainbow/stopnc.sh:

PS2, Line 20: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RemoteAsterixDriverKill.java
File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RemoteAsterixDriverKill.java:

PS2, Line 30: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/killdrivers.sh
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/killdrivers.sh:

PS2, Line 3: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-installer/src/main/resources/zookeeper/stop_zk
File asterixdb/asterix-installer/src/main/resources/zookeeper/stop_zk:

PS2, Line 24: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/kill_cc_and_nc.sh
File asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/kill_cc_and_nc.sh:

PS2, Line 18: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/kill_cc_and_nc.sh
File asterixdb/asterix-installer/src/test/resources/transactionts/scripts/dml_recovery/kill_cc_and_nc.sh:

PS2, Line 18: grep
Just stick to awk here?


https://asterix-gerrit.ics.uci.edu/#/c/1563/2/asterixdb/asterix-installer/src/test/resources/transactionts/scripts/recover_after_abort/primary_index_only/kill_cc_and_nc.sh
File asterixdb/asterix-installer/src/test/resources/transactionts/scripts/recover_after_abort/primary_index_only/kill_cc_and_nc.sh:

PS2, Line 18: grep
Just stick to awk here?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1563
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb52d2a2696c8c43af92fda9b6806d9798bf881
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message