asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix log redirection in Ansible start cluster scripts.
Date Mon, 06 Mar 2017 21:35:47 GMT
Michael Blow has posted comments on this change.

Change subject: Fix log redirection in Ansible start cluster scripts.
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1553/1/asterixdb/asterix-server/src/main/opt/ansible/yaml/start_cc.yml
File asterixdb/asterix-server/src/main/opt/ansible/yaml/start_cc.yml:

PS1, Line 29: &
This is a race-condition, assumes the fork starts before the shell exits.  I would add append
a sleep 1s to this.


https://asterix-gerrit.ics.uci.edu/#/c/1553/1/asterixdb/asterix-server/src/main/opt/ansible/yaml/start_ncservice.yml
File asterixdb/asterix-server/src/main/opt/ansible/yaml/start_ncservice.yml:

Line 21:   shell: nohup "{{ ncservice }}" >> "{{ binarydir }}/logs/ncservice.log" 2>&1
&
This is a race-condition, assumes the fork starts before the shell exits.  I would add append
a sleep 1s to this.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1553
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia62a9f5d313c5d7ad0629af95199c2f7b4538435
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message