asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add job cancellation support in Hyracks.
Date Sat, 04 Mar 2017 00:03:58 GMT
Yingyi Bu has posted comments on this change.

Change subject: Add job cancellation support in Hyracks.
......................................................................


Patch Set 9:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1537/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/CancelJobWork.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/CancelJobWork.java:

PS8, Line 3:  * or more contributor license agreements.  See the NOTICE file
           :  * distributed with this work for additional information
           :  * regarding copyright ownership.  The ASF licenses this file
           :  * to you under the Apache License, Version 2.0 (the
           :  * "License"); you may not use this file except in compliance
           :  * with the License.  You may obtain a copy of the License at
           :  *
           :  *    http://www.apache.org/licenses/LICENSE-2.0
           :  *
           :  * Unless required by applicable law or agreed to in writing,
           :  * software distributed under the License is distributed on an
           :  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
           :  * KIND, either express or implied.  See the License for the
           :  * specific language governing permissions and limitations
           :  * under the License.
           :  */
> double indentation
Done


https://asterix-gerrit.ics.uci.edu/#/c/1537/8/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/CancelJobTest.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/CancelJobTest.java:

PS8, Line 1: /*
           :  * Licensed to the Apache Software Foundation (ASF) under one
           :  * or more contributor license agreements.  See the NOTICE file
           :  * distributed with this work for additional information
           :  * regarding copyright ownership.  The ASF licenses this file
           :  * to you under the Apache License, Version 2.0 (the
           :  * "License"); you may not use this file except in compliance
           :  * with the License.  You may obtain a copy of the License at
           :  *
           :  *    http://www.apache.org/licenses/LICENSE-2.0
           :  *
           :  * Unless required by applicable law or agreed to in writing,
           :  * software distributed under the License is distributed on an
           :  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
           :  * KIND, either express or implied.  See the License for the
           :  * specific language governing permissions and limitations
           :  * under the License.
           :  */
           : 
           : pac
> Double indentation.
Done


PS8, Line 65: s executin
> It seems that these are actually 6 separate tests. I think that it could be
Done


https://asterix-gerrit.ics.uci.edu/#/c/1537/8/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/collection/ListMap.java
File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/collection/ListMap.java:

PS8, Line 1: 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
> double indentation
Done


PS8, Line 39: 
> What's the difference to Java's LinkedHashMap?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1537/8/hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/collection/ListMapTest.java
File hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/collection/ListMapTest.java:

PS8, Line 3: 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
           : 
> Double indentation.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1537
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26330c19c8642dd3246739b5150c4aa667c359c
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message