asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Feed Adaptor and RecordReader Clean
Date Thu, 02 Mar 2017 01:31:46 GMT
Xikui Wang has posted comments on this change.

Change subject: Feed Adaptor and RecordReader Clean
......................................................................


Patch Set 3:

(3 comments)

Added one Q to StreamRecordReaderFactory

https://asterix-gerrit.ics.uci.edu/#/c/1535/3/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS3, Line 148: name
> Could we add the adaptor name to the message?
Will address these two in next submit.


https://asterix-gerrit.ics.uci.edu/#/c/1535/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/LineRecordReader.java:

Line 107:                         {
> Why do we have 2 nested blocks here?
blindly copied from previous code. Will address this in next update.


https://asterix-gerrit.ics.uci.edu/#/c/1535/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/StreamRecordReaderFactory.java:

PS3, Line 97: recordReader
> Just return the RecordReader here?
Quick Q: Here this factory will return one of the implementation of StreamRecordReader. The
class hierarchy would be like this: 
RecordReader -> TwitterRecordReader, StreamRecordReader, etc. ->   StreamRecordReaderImplementations(Semistructure,LineRecord,
etc.) 
The constructor for StreamRecordReaders is slightly different as for the input stream. That's
not necessary for the other record readers. In this case, probably StreamRecordReader is a
better option?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1535
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699657ddd8408fd00bcbd7df57b6610ef3692a1a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message