asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <>
Subject Change in asterixdb[master]: Feed Adaptor and RecordReader Clean
Date Thu, 02 Mar 2017 01:31:46 GMT
Xikui Wang has posted comments on this change.

Change subject: Feed Adaptor and RecordReader Clean

Patch Set 3:


Added one Q to StreamRecordReaderFactory
File asterixdb/asterix-common/src/main/resources/asx_errormsg/

PS3, Line 148: name
> Could we add the adaptor name to the message?
Will address these two in next submit.
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/

Line 107:                         {
> Why do we have 2 nested blocks here?
blindly copied from previous code. Will address this in next update.
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/

PS3, Line 97: recordReader
> Just return the RecordReader here?
Quick Q: Here this factory will return one of the implementation of StreamRecordReader. The
class hierarchy would be like this: 
RecordReader -> TwitterRecordReader, StreamRecordReader, etc. ->   StreamRecordReaderImplementations(Semistructure,LineRecord,
The constructor for StreamRecordReaders is slightly different as for the input stream. That's
not necessary for the other record readers. In this case, probably StreamRecordReader is a
better option?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I699657ddd8408fd00bcbd7df57b6610ef3692a1a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Michael Blow <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Xikui Wang <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message