asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb-bad[master]: Updated BAD to work with recent Asterix changes
Date Wed, 01 Mar 2017 23:55:38 GMT
Steven Jacobs has posted comments on this change.

Change subject: Updated BAD to work with recent Asterix changes
......................................................................


Patch Set 1:

(1 comment)

Uploading a new patch set that should build

https://asterix-gerrit.ics.uci.edu/#/c/1539/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java:

Line 121:                     ResultUtil.printResults(resultReader, ((QueryTranslator) statementExecutor).getSessionConfig(),
> Is this not-open intentionally? Do we need to open it explicitly?
Till's refactoring of resultReader makes this call no longer necessary


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1539
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20f2e86ff47f92477ffc1d20514127af41340346
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message