Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0E34200C31 for ; Tue, 21 Feb 2017 09:37:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CF93A160B3E; Tue, 21 Feb 2017 08:37:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2CC01160B74 for ; Tue, 21 Feb 2017 09:37:53 +0100 (CET) Received: (qmail 25399 invoked by uid 500); 21 Feb 2017 08:37:52 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 25304 invoked by uid 99); 21 Feb 2017 08:37:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 08:37:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CCE37C663A for ; Tue, 21 Feb 2017 08:37:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kKwpGbY-o4-a for ; Tue, 21 Feb 2017 08:37:51 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AB8045FE4F for ; Tue, 21 Feb 2017 08:37:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 63782240F7F; Tue, 21 Feb 2017 00:37:50 -0800 (PST) Date: Tue, 21 Feb 2017 00:37:50 -0800 From: "abdullah alamoudi (Code Review)" To: Till Westmann CC: Jenkins , Michael Blow Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1786: Remove Hyracks Servlets. X-Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba X-Gerrit-ChangeURL: X-Gerrit-Commit: baee09dfd086e5139dea675407f3e8d2d67d3f65 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Message-Id: <20170221083750.63782240F7F@unhygienix.ics.uci.edu> archived-at: Tue, 21 Feb 2017 08:37:54 -0000 abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1786: Remove Hyracks Servlets. ...................................................................... Patch Set 10: Code-Review+2 (3 comments) Few comments. Feel free to ignore the renaming ones (Your call). as for the third one, you can either address it or create a JIRA, or a todo comment for it. https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/ApplicationInstallationHandler.java: PS10, Line 43: ApplicationInstallationHandler this should be renamed to match the convention for servlets? https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/web/WebServer.java: PS10, Line 70: JSONOutputRequestHandler not sure anymore if we should rename to match the servlet naming convention. your call till https://asterix-gerrit.ics.uci.edu/#/c/1508/10/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java: PS10, Line 70: HttpMethod.POST need to understand how this affect existing servlets as they were written with the assumption that a non Get and non Post request will not get through. -- To view, visit https://asterix-gerrit.ics.uci.edu/1508 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcd240591d12baab2db4ce3163c635a1dde5c4ba Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes