asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runt...
Date Fri, 24 Feb 2017 02:27:21 GMT
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1791, ASTERIXDB-1796: fix failure handling in runtime operators.
......................................................................


Patch Set 13:

(12 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1513/11/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java:

PS11, Line 132: IS_OS_WINDOWS
> Let's file an issue for windows.
Done. Filed ASTERIXDB-1810.


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/failure/q18_large_volume_customer_failure/q18_large_volume_customer_failure.2.update.sqlpp:

PS11, Line 22: 
> linebreak?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java:

PS11, Line 79: another
> fix line length?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/RunFileWriter.java
File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/RunFileWriter.java:

PS11, Line 74: 
> Wondering if we should null-out the file reference to check that we don't a
Done


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HybridHashJoinOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HybridHashJoinOperatorDescriptor.java:

PS11, Line 532: 
> Why don't we need to close the join if the while loop throws?
closeJoin(writer) doesn't call writer.close() but only call writer.nextFrame(), however, it
closes hashtable, memmgr, and probe runfiles. 

Therefore, I separated closeProbe into two functions:
completeJoin(writer) which calls writer.nextFrame()
releaseMemory() which closes other resources.


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java:

PS11, Line 444: eteAft
> If we exit here, doesn't the finally block below close r again? Is that saf
Done


https://asterix-gerrit.ics.uci.edu/#/c/1513/11/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java:

PS11, Line 458:     throw e;
> If we fail before we get to close(), we logProbeComplete. But when we fail 
Done


PS11, Line 574: HybridHashJoi
> Move this before the "try"? That would make the "open" the first statement 
Done


PS11, Line 581: 
> Only if we don't throw.
Line 665-666 rescues all cases:-)
But I added try-finally here to make it more clear.


PS11, Line 593:  {
> Same as above, not necessarily closed - is that ok?
closeProbe(writer) doesn't call writer.close() but only call writer.nextFrame(), however,
it closes hashtable, memmgr, and probe runfiles. Therefore, I separated closeProbe into two
functions:

completeProble(writer) which calls writer.nextFrame()

releaseResource() which closes other resources.


PS11, Line 747: 
> This could throw as well. Is that a problem?
Done


PS11, Line 773:  applyNest
> This could throw as well. Is that a problem?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1513
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I203168171e6dac16b57d2eda960823e3810e22a3
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message