asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix the names of Let to Servlet
Date Sat, 11 Feb 2017 02:02:14 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8
> The sake of brevity, as I mentioned in HttpUtil.
Done. Only for you Mike


https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java:

PS3, Line 23: Servlets
> Why not just make this enum a top-level class?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message