asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Carey (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1747 Implemented full lifecycle capabilities for d...
Date Tue, 07 Feb 2017 19:34:51 GMT
Michael Carey has posted comments on this change.

Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for distributed jobs
......................................................................


Patch Set 11:

Actually, regarding "Addressed comments. As far as tests go, the functionality is tested in
BAD, which is run against all changes to Asterix, which should prevent regression."  Nope!
 We need to make sure that we have tests along with code where the code lives - so the two
options here would be to move the relevant unit tests up into master to make sure this is
tested, or to move the code down into BAD where it is currently being tested.  Either is fine.
 We can't have master depending on extensions for QA.  Thx!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1377
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message