asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Change "samples" to "opt" in the distribution package.
Date Mon, 06 Feb 2017 17:55:44 GMT
Yingyi Bu has posted comments on this change.

Change subject: Change "samples" to "opt" in the distribution package.
......................................................................


Patch Set 6:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1482/5/README.md
File README.md:

PS5, Line 79: start
> I'd keep the "sample-cluster" in the name. The directory "local" already ha
Done


https://asterix-gerrit.ics.uci.edu/#/c/1482/5/asterixdb/asterix-server/src/main/opt/local/bin/start.bat
File asterixdb/asterix-server/src/main/opt/local/bin/start.bat:

PS5, Line 91: 
> I'd also leave "sample-cluster" here.
Done


PS5, Line 109: 
> I'd also leave "sample-cluster" here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1482/5/asterixdb/asterix-server/src/main/opt/local/bin/start.sh
File asterixdb/asterix-server/src/main/opt/local/bin/start.sh:

PS5, Line 82: 
> I'd also leave "sample-cluster" here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1482/5/asterixdb/asterix-server/src/main/opt/local/bin/stop.bat
File asterixdb/asterix-server/src/main/opt/local/bin/stop.bat:

PS5, Line 79: 
> I'd also leave "sample-cluster" here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1482/5/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java:

PS5, Line 81: stop
> I'd also leave "sample-cluster" here.
Done


PS5, Line 84: start
> I'd also leave "sample-cluster" here.
Done


PS5, Line 100: stop
> I'd also leave "sample-cluster" here.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1482
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7876376d089b9ebebba3d37ac90ac346a741be3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message