asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enable commit runtime extension
Date Fri, 03 Feb 2017 23:32:42 GMT
Yingyi Bu has posted comments on this change.

Change subject: Enable commit runtime extension
......................................................................


Patch Set 1:

(4 comments)

I'm not sure why the change ABooleanSerializerDeserializer -> BooleanPointable is relevant.
 I doubt it's a case that "by accident, it works."  In principle, *DB should have the full
control of its own data types and their runtime formatting.   In short, the bottomline is
that *DB's data format is determined by an *DB class rather than replies on hyracks.

https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java:

PS1, Line 265: BooleanPointable
I'm not sure if ABooleanSerializerDeserializer considers care of type tag?


https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/BooleanBinaryComparatorFactory.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/BooleanBinaryComparatorFactory.java:

PS1, Line 41: BooleanPointable
I'm not sure if that works:

-- BooleanPointable is a hyracks level thing
-- This class is in *DB -- potentially *DB can have its own format, e.g., type tag etc.


https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java:

PS1, Line 33: BooleanPointable
Similar considers for boolean.


https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ShortWithoutTypeInfoPrinterFactory.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ShortWithoutTypeInfoPrinterFactory.java:

PS1, Line 33: BooleanPointable
I doubt this is "by accident, it works.."


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1485
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98083ea5e93cb5f45d92c5dfbacfee1020fad57a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message