asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Introduce IStorageComponentProvider
Date Thu, 02 Feb 2017 06:20:06 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Introduce IStorageComponentProvider
......................................................................


Patch Set 16:

(10 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java:

PS16, Line 33: TransactionUtils
> TransactionUtils -> TranslationUtil
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

Line 197:                     statementExecutorFactory.create(aqlStatements, sessionConfig,
compilationProvider, componentProvider);
> Format?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/IApplicationContextInfo.java:

PS16, Line 28: IStorageManagerInterface
> IStorageManagerInterface -> IStorageComponentProvider
Done


PS16, Line 29: implementation
> add "IGlobalRecoveryManager" and "ILibraryManager".
Done


PS16, Line 43: IRuntimeComponentProvider
> IRuntimeComponentProvider -> IStorageComponentProvider
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtils.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/TransactionUtils.java:

PS16, Line 30: TransactionUtils
> TransactionUtils -> TransactionUtil
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java:

PS16, Line 392: static
> Move static methods to a util class.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMInvertedIndexLocalResourceMetadata.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMInvertedIndexLocalResourceMetadata.java:

PS16, Line 85: LocalResource
> format?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMRTreeLocalResourceMetadata.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMRTreeLocalResourceMetadata.java:

PS16, Line 86: LocalResource
> format?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1451/16/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

PS16, Line 49: replication
> alphabetically ordered?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1451
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If86750cdb2436c713f6598e54d4aaaf23d9f7bbf
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message