Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EF384200C09 for ; Wed, 25 Jan 2017 10:02:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EA3E8160B50; Wed, 25 Jan 2017 09:02:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4154D160B4E for ; Wed, 25 Jan 2017 10:02:25 +0100 (CET) Received: (qmail 57456 invoked by uid 500); 25 Jan 2017 09:02:24 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 57447 invoked by uid 99); 25 Jan 2017 09:02:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 09:02:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0FC411A0587 for ; Wed, 25 Jan 2017 09:02:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.127 X-Spam-Level: ** X-Spam-Status: No, score=2.127 tagged_above=-999 required=6.31 tests=[HK_RANDOM_REPLYTO=0.001, MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uFm4q0HHerlw for ; Wed, 25 Jan 2017 09:02:23 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 17E915F238 for ; Wed, 25 Jan 2017 09:02:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 632482420B1; Wed, 25 Jan 2017 01:02:14 -0800 (PST) Date: Wed, 25 Jan 2017 01:02:14 -0800 From: "Xikui Wang (Code Review)" CC: Jenkins , Till Westmann , Michael Blow Reply-To: xkkwww@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Modularize feed adaptors X-Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3a09fbd48b79e293ac4c86533954793c5dbf9ba7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20170125090214.632482420B1@unhygienix.ics.uci.edu> archived-at: Wed, 25 Jan 2017 09:02:26 -0000 Xikui Wang has posted comments on this change. Change subject: Modularize feed adaptors ...................................................................... Patch Set 9: @Mike B, The further modularization comment turns out to be very useful! Quite some knowledge about Maven is gained from this process.. The quirky part about this patch is, I can't really have adaptor related dependencies resides at the villain module, because that will cause unused lib issue for the villain test framework part. So I duplicated some of them in each of the twitter-adaptor module and rss-adaptor module. I guess the right answer would be use the AQLTestExcution load scripts from villain package and add villain-module as its dependency. Currently, These executionTests are included in asterix-app which will cause recursive dependency issue... I guess there is no better solution for that now? -- To view, visit https://asterix-gerrit.ics.uci.edu/1430 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No