Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 018CC200C0E for ; Wed, 18 Jan 2017 05:43:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0005E160B52; Wed, 18 Jan 2017 04:43:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47362160B46 for ; Wed, 18 Jan 2017 05:43:58 +0100 (CET) Received: (qmail 9356 invoked by uid 500); 18 Jan 2017 04:43:57 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 9347 invoked by uid 99); 18 Jan 2017 04:43:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 04:43:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C1D7FC1869 for ; Wed, 18 Jan 2017 04:43:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.92 X-Spam-Level: X-Spam-Status: No, score=0.92 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a7or1WMAv8mY for ; Wed, 18 Jan 2017 04:43:56 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DA07E5F576 for ; Wed, 18 Jan 2017 04:43:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 91E6924062D; Tue, 17 Jan 2017 20:43:55 -0800 (PST) Date: Tue, 17 Jan 2017 20:43:55 -0800 From: "Yingyi Bu (Code Review)" To: Taewoo Kim CC: Jenkins Reply-To: buyingyi@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller X-Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2 X-Gerrit-ChangeURL: X-Gerrit-Commit: d5cf79c76685baea4af83653ff8e3ec450a771c7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20170118044355.91E6924062D@unhygienix.ics.uci.edu> archived-at: Wed, 18 Jan 2017 04:43:59 -0000 Yingyi Bu has posted comments on this change. Change subject: AQLPlus Refactoring 1: add a new rule controller ...................................................................... Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java File hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java: Line 68: // Checks whether the first rule returns true. Make sure that empty input collection can still work gracefully? -- To view, visit https://asterix-gerrit.ics.uci.edu/1432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes