asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb-bad[master]: Match Changes to Asterix insert with return clause
Date Mon, 02 Jan 2017 20:53:04 GMT
Steven Jacobs has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1412

Change subject: Match Changes to Asterix insert with return clause
......................................................................

Match Changes to Asterix insert with return clause

commit 00a5084abddf2783b2dcac1eca09ee27b966a711
Author: Steven Glenn Jacobs <sjaco002@ucr.edu>
Date:   Mon Jan 2 12:51:49 2017 -0800

    Attempt to match Yingyi's change

Change-Id: I9fc3b5ebcaab5f00965e654f061967251a0febd8
---
M asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/12/1412/1

diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
index 85ee0fc..af7394e 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
@@ -196,20 +196,18 @@
                 VariableExpr useResultVar = new VariableExpr(new VarIdentifier("$result",
0));
                 useResultVar.setIsNewVar(false);
                 useSubscriptionVar.setIsNewVar(false);
-                Query returnQuery = new Query(false);
                 List<Clause> clauseList = new ArrayList<>();
                 LetClause let = new LetClause(subscriptionVar,
                         new FieldAccessor(useResultVar, new Identifier(BADConstants.SubscriptionId)));
                 clauseList.add(let);
                 FLWOGRExpression body = new FLWOGRExpression(clauseList, useSubscriptionVar);
-                returnQuery.setBody(body);
 
                 metadataProvider.setResultSetId(new ResultSetId(resultSetIdCounter++));
                 metadataProvider.setResultAsyncMode(
                         resultDelivery == ResultDelivery.ASYNC || resultDelivery == ResultDelivery.DEFERRED);
                 InsertStatement insert = new InsertStatement(new Identifier(dataverse),
                         new Identifier(subscriptionsDatasetName), subscriptionTuple, varCounter,
resultVar,
-                        returnQuery);
+ body);
                 ((QueryTranslator) statementExecutor).handleInsertUpsertStatement(metadataProvider,
insert, hcc, hdc,
                         resultDelivery, stats, false);
             } else {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fc3b5ebcaab5f00965e654f061967251a0febd8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco002@ucr.edu>

Mime
View raw message