asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Introduce IStorageComponentProvider
Date Mon, 23 Jan 2017 02:06:42 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Introduce IStorageComponentProvider
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java:

Line 260:                             compactionInfo.first, compactionInfo.second);
> How do you capture isPartitioned in the new code?
inside the call :) but I am sure you know that already by this time...


https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/ValidateUtil.java:

Line 31: import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
> I think the exception used here should be CompilationException, with error 
mostly using compilation exception in the implementation. though, fixing all of them is a
lot of "boring" work. I however, fixed a bunch.


https://asterix-gerrit.ics.uci.edu/#/c/1451/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/StorageManager.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/StorageManager.java:

Line 25: public class StorageManager implements IStorageManager {
> The storage manager is instantiated at a number of places in the code base,
I agree. but metadata initialization :(( we can still do something about it... later?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1451
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If86750cdb2436c713f6598e54d4aaaf23d9f7bbf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message