asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller
Date Wed, 18 Jan 2017 05:27:17 GMT
Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 53:     @Override
> This part, it would be nice if you can provide an unit test that I can refe
APIFrameworkTest, ExceptionTest, NullMissingTest, and
ConnectorAPIServletTest are examples.

You can refer to the MockIto doc:
http://static.javadoc.io/org.mockito/mockito-core/2.6.3/org/mockito/Mockito.html

Simple mock example:
http://static.javadoc.io/org.mockito/mockito-core/2.6.3/org/mockito/Mockito.html#verification

Verify call counts:
http://static.javadoc.io/org.mockito/mockito-core/2.6.3/org/mockito/Mockito.html#4

It's powerful and allows you to test anything easily.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message