asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Applied the multiway fuzzyjoin based on the prefix-based joi...
Date Wed, 18 Jan 2017 00:55:51 GMT
Taewoo Kim has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin
testCases.
......................................................................


Patch Set 39:

(5 comments)

A few comments on the commit message

https://asterix-gerrit.ics.uci.edu/#/c/1076/39//COMMIT_MSG
Commit Message:

Line 9: - Enabled the fuzzyjoin rule.
Enabled -> Enable


Line 10: - Introduced eight existing rules in FuzzyJoinRuleCollections after applied the fuzzyjoin
rule.
Introduced -> Introduce


Line 18:   - hybrid multiway fuzzyjoin with the both forms of fuzzyjoins.
Could you tell me what "link-like", "star-like" and "hybrid"? We can discuss via Skype.


Line 19: - Add a running Cases for select-fuzzyjoin.
What is select-fuzzyjoin?


Line 20: - Change the inverted-based fuzzyjoin onto prefix-based join due to the efficiency
considerations.
inverted-based -> inverted-index-based 

onto -> to


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 39
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Chen Li <chenli@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-HasComments: Yes

Mime
View raw message