asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix overflow for dynamic parameter setting
Date Sat, 14 Jan 2017 03:32:15 GMT
Yingyi Bu has posted comments on this change.

Change subject: Fix overflow for dynamic parameter setting
......................................................................


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1438/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

Line 70:                 / (long) (16 * getMemoryComponentPageSize()));
Why does the original formula overflow?  storageMemorycomponentGlobalbudgetDefault is a long
value.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69d5e3f80916fc8525a0267abb4ca8ddabb73649
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message