asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Subset hive-exec, make twitter4j a provided dep.
Date Thu, 12 Jan 2017 19:47:24 GMT
Ian Maxon has posted comments on this change.

Change subject: Subset hive-exec, make twitter4j a provided dep.
......................................................................


Patch Set 7:

(2 comments)

My intention was to change it as little as possible, so I don't  know, won't we have to change
the import in the actual external data stuff in that case?

https://asterix-gerrit.ics.uci.edu/#/c/1427/7/asterixdb/asterix-external-data-tools/pom.xml
File asterixdb/asterix-external-data-tools/pom.xml:

Line 54:       <version>0.13.0</version>
> Can we move all/some of these versions to dependencyManagement?
Which ones, just the Hive/Hadoop ones?


https://asterix-gerrit.ics.uci.edu/#/c/1427/7/asterixdb/asterix-external-data/pom.xml
File asterixdb/asterix-external-data/pom.xml:

Line 406:       <version>2.5</version>
> Version from dep mgmt?
Yeah, it just complained, so I obliged. I don't quite get why it changed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4276f540ec8552181bfb452882654b5faa17df
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message