asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Full-text implementation step 3
Date Fri, 06 Jan 2017 18:28:38 GMT
Yingyi Bu has posted comments on this change.

Change subject: Full-text implementation step 3
......................................................................


Patch Set 24:

(14 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 207:                 throw new AlgebricksException("Each element in the list should be
a string in the Full-text search.");
Follow the latest error message proposal:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling


Line 244:                         "Phrase search in Full-text is not yet supported. Only one
keyword per expression is permitted."
Follow the latest error message proposal: https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/fulltext-contains-without-option.aql
File asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/fulltext-contains-without-option.aql:

Line 50: write output to asterix_nc1:"rttest/inverted-index-basic_fulltext-contains-without-option.adm";
you don't need that write statement?


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/fulltext-contains.aql
File asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/fulltext-contains.aql:

Line 50: write output to asterix_nc1:"rttest/inverted-index-basic_fulltext-contains.adm";
you don't need this write statement?


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-04/fulltext-index-04.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-04/fulltext-index-04.2.update.aql:

Line 18:  */
remove the empty file and re-index files.


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-05/fulltext-index-05.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-05/fulltext-index-05.2.update.aql:

Line 19: 
remove empty file and re-index files.


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-06/fulltext-index-06.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/fulltext/fulltext-index-06/fulltext-index-06.2.update.aql:

Line 18:  */
remove empty file and re-index files.


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

Line 2469:         <output-dir compare="Text">fulltext-index-01</output-dir>
Why there are less test queries in SQL++?


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java:

Line 1038:         addFunction(FULLTEXT_CONTAINS, ABooleanTypeComputer.INSTANCE, true);
The type computer is not right.  It doesn't check input types at compile time.


Line 1039:         addFunction(FULLTEXT_CONTAINS_WO_OPTION, ABooleanTypeComputer.INSTANCE,
true);
The type computer is not right.  It doesn't check input types at compile time.


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

Line 340: 
Please cleanup "temp:"


Line 349:                 errorMessage = errorMessage.concat(d.toString() + '\n');
Using the new error message proposal:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling


https://asterix-gerrit.ics.uci.edu/#/c/1388/24/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/AbstractTOccurrenceSearcher.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/AbstractTOccurrenceSearcher.java:

Line 125:                                 "Phrase search in Full-text is not supported. "
Please follow the exception handing proposal:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling


Line 131:                                 throw new HyracksDataException(
Please follow the exception handing proposal:
https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1388
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1087854ac7cf5b6ef5094e27a1646f12f6a8653f
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message