asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Runtime ErrorCode fix in external data
Date Thu, 05 Jan 2017 22:32:55 GMT
Yingyi Bu has posted comments on this change.

Change subject: Runtime ErrorCode fix in external data
......................................................................


Patch Set 6:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java:

Line 125:             String message = "Unable to create adapter as class loader not configured
for library " + adaptorLibraryName
Remove the hardcoded message.

Instead, 

RuntimeDataException exception = new RuntimeDataException(...)

LOGGER.severe(message);

throw exception;


Line 129:                     ErrorCode.ERROR_OPERATORS_FEED_INTAKE_OPERATOR_DESCRIPTOR_CLASSLOADER_NOT_CONFIGURED);
The exception requires two parameters:

3004 = Unable to create adapter as class loader not configured for library %1$s in dataverse
%2$s


https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/DelimitedDataParserFactory.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/DelimitedDataParserFactory.java:

Line 92:                     ErrorCode.ERROR_PARSER_FACTORY_DELIMITED_DATA_PARSER_FACTORY_QUOTE_DELIMITER_MISMATCH);
The error message requires two parameters.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1374
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message