asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1714: Eliminate dependency on org.json
Date Thu, 05 Jan 2017 03:06:53 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1714: Eliminate dependency on org.json
......................................................................


Patch Set 13:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.query.sqlpp:

Line 20: select element x from Metadata.Datatype as x;
> I thought this was not order by before? I changed it so I thought I was cha
Hmm, to me it showed up as a change ...


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java:

Line 45:     public static String convertNode(final JsonNode node) throws JsonProcessingException
{
> Sure, it's just to sort a node so it always gets outputted the same way for
Could you add the comment to the code?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:

Line 549:             e.printStackTrace();
> Generally with servlets though you don't want to throw exceptions to the to
But this is a servlet test client, right? So it should be fine to report errors loudly.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1392
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c5400fd134ae75d43385255af7794e968b1c7e
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message