asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1714: Eliminate dependency on org.json
Date Wed, 04 Jan 2017 06:26:55 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1714: Eliminate dependency on org.json
......................................................................


Patch Set 13:

(111 comments)

Yay, no more org.json!

I've got one big question

- The cluster state serialization has changed - why is that?

and a number of smaller comments/proposals which mostly fall into 3 categories

1) Use one (or 2 if we separate AsterixDB and Hyracks) version number (2.8.4?) for all Jackson
dependencies.

2) Replace ObjectNode.put() with ObjectNode.set() when the value is a JsonNode.

3) Small WS fixes.

Also, it would reduce the size of the change a bit if all the files that only have their line-ending
changed would be reverted.

https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/pom.xml
File asterixdb/asterix-app/pom.xml:

Line 333:     </dependency>
This seems to be a duplicate.

Also, could we pull the version out to a dependencyManagement section in the root POM to avoid
repeating the version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 316:                             .println(new ObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(spec.toJSON()));
> MAJOR SonarQube violation:
Indeed. Could we split this into 2 lines?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterAPIServlet.java:

Line 74:         ObjectNode json;
Could we move this declaration into the try { ... }?


Line 75:         ObjectMapper om = new ObjectMapper();
This ObjectMapper seems to be unused. Is it?


Line 134:         ObjectMapper om = new ObjectMapper();
Could we create this directly before we use it?


Line 136:         json = ClusterStateManager.INSTANCE.getClusterStateDescription();
Put those 2 lines into 1 line?


Line 160:             json.put("cc", cc);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterCCDetailsAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterCCDetailsAPIServlet.java:

Line 45:         ObjectNode json;
Move this down into the try{....}?


Line 68:         ObjectMapper om = new ObjectMapper();
Create the ObjectMapper just before the switch?


Line 96:         ObjectMapper om = new ObjectMapper();
Move this down?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java:

Line 59:                 json.put("ncs", getClusterStateJSON(request, "../").get("ncs"));
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 81:         ObjectMapper om = new ObjectMapper();
Move this down to where it's used?


Line 91:                 ObjectNode json = (ObjectNode) ncs.get(i);
Pull this into the if (...)?


Line 135:                 json.put(newKey, json.remove(key));
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 163:             } else if (json.get(key) instanceof ArrayNode) {
Only do "json.get(key)" once?


Line 169:                 final Object value = valueArray.get(index);
Could we make "value" a JsonNode and then use "set" instead of "putPOJO" 2 lines below?


Line 174:         List<ObjectNode> gcs = new ArrayList<>();
Would using an ArrayNode work here? Then we could probably also replace the 

    json.putPOJO("gcs", gcs);

with a "set".


Line 178:             gc.put("name", gcNames.get(i));
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 179:             gc.put("collection-time", ((ArrayNode)gcCollectionTimes.get(i)).get(index));
These casts to ArrayNode are not required, I think.


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java:

Line 131:                                     String primaryKeys, boolean temp, Map<String,
NodeControllerInfo> nodeMap) throws Exception {
> MAJOR SonarQube violation:
Yes, please.


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DiagnosticsAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/DiagnosticsAPIServlet.java:

Line 82:         ccFutureData.put("threaddump", executor.submit(() -> fixupKeys((ObjectNode)om.readTree(hcc.getThreadDump(null)))));
> MAJOR SonarQube violation:
Yes, please.


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java:

Line 314:         SessionConfig.ResultDecorator handlePrefix = new SessionConfig.ResultDecorator()
{
Why did we need this change?


Line 402:                 addStack);
Could be put this back? Or does it cause problems?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java:

Line 78:                 nc.put(PID, details.get(PID));
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 83:             jsonObject.put("cluster", clusterState);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 85:             writer.print(om.writeValueAsString(jsonObject));
Replace by

    om.writeValue(writer, jsonObject);

? (Not sure if that's the same result ...).


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java:

Line 161:         try {
Move the try-catch into "displayRecord"?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultUtil.java:

Line 105:         errorResp.put("error-code", errorArray);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java:

Line 153:         expectedResponse.put("type", recordType.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 163:         expectedResponse.put("splits", splitsArray);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java:

Line 110:         for(Map.Entry<String,String> e: propMap.entrySet()){
Some spaces around the parens?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.query.sqlpp:

Line 20: select element x from Metadata.Datatype as x;
Will this return consistent results without "order by"? Is there only one result?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

Line 9:     "cluster.partitions" : {
The content looks different here. Was that a conscious decision?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm:

Line 9:     "cluster.partitions" : {
same here


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm:

Line 9:     "cluster.partitions" : {
and here


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-client-helper/pom.xml
File asterixdb/asterix-client-helper/pom.xml:

Line 113:       <version>2.8.1</version>
This is a different version that in another pom - could we have just one (shared) version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/pom.xml
File asterixdb/asterix-common/pom.xml:

Line 313:       <version>2.8.1</version>
Again, a shared version.


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java:

Line 45:     public static String convertNode(final JsonNode node) throws JsonProcessingException
{
This looks pretty involved. Could you add a short comment what's special here?


Line 94:             }
Pull this into a private method for reuse in appendAry?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java:

Line 125:         res.put("handle", handle);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/SingleLinePrettyPrinter.java
File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/SingleLinePrettyPrinter.java:

Line 281: //        if (!_objectIndenter.isInline()) {
Should we remove the commented code?


Line 330: //        if (!_objectIndenter.isInline()) {
Should we remove the commented code?


Line 344: //        if (!_arrayIndenter.isInline()) {
Should we remove the commented code?


Line 374: //        if (!_arrayIndenter.isInline()) {
Should we remove the commented code?


Line 386: //        gen.writeRaw(' ');
Should we remove the commented code?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:

Line 34: import java.util.*;
Could you revert this change?


Line 549:             e.printStackTrace();
I think that we should wrap and throw the exception here.


Line 976:                             // <library-directory>
Oups


Line 1027:         if(nodePid <=1 ){
fix space?


Line 1134:             for (int i=0;i<result.size();i++) {
fix ws?


Line 1136:                 if(json != null) {
fix ws?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-installer/src/test/resources/integrationts/replication/results/failback/node_failback/node_failback.cluster_state.10.adm
File asterixdb/asterix-installer/src/test/resources/integrationts/replication/results/failback/node_failback/node_failback.cluster_state.10.adm:

Line 5:       "partitionId" : 0,
Again the change from the the string encoding to an object encoding. Is that intended?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-installer/src/test/resources/integrationts/replication/results/failback/node_failback/node_failback.cluster_state.5.adm
File asterixdb/asterix-installer/src/test/resources/integrationts/replication/results/failback/node_failback/node_failback.cluster_state.5.adm:

Line 3:   "partitions" : {
One more.


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-maven-plugins/record-manager-generator-maven-plugin/pom.xml
File asterixdb/asterix-maven-plugins/record-manager-generator-maven-plugin/pom.xml:

Line 53:       <version>2.8.1</version>
Align version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACircle.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ACircle.java:

Line 90:         circle.put("center", center.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 92:         json.put("ACircle", circle);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADayTimeDuration.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADayTimeDuration.java:

Line 52:         json.put("ADuration", duration);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADuration.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADuration.java:

Line 128:         json.put("ADuration", duration);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ALine.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ALine.java:

Line 83:         line.put("p1", p1.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 84:         line.put("p2", p2.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 85:         json.put("ALine", line);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AOrderedList.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AOrderedList.java:

Line 137:         json.put("AOrderedList", list);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint.java:

Line 84:         json.put("APoint", point);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint3D.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APoint3D.java:

Line 92:         json.put("APoint3D", point);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APolygon.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/APolygon.java:

Line 106:         json.put("APolygon", polygon);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java:

Line 115:             item.put(type.getFieldNames()[i], fields[i].toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 118:         json.put("ARecord", record);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARectangle.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ARectangle.java:

Line 83:         rectangle.put("p1", p1.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 84:         rectangle.put("p2", p2.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 85:         json.put("ARectangle", rectangle);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUnorderedList.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AUnorderedList.java:

Line 128:         json.put("AUnorderedList", list);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AYearMonthDuration.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AYearMonthDuration.java:

Line 60:         json.put("ADuration", duration);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AOrderedListType.java:

Line 83:         type.put("item-type", itemType.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java:

Line 344:             field.put(fieldNames[i], fieldTypes[i].toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 348:         type.put("fields", fields);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnionType.java:

Line 221:         type.put("fields", fields);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java:

Line 84:         type.put("item-type", itemType.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java:

Line 644:         stateDescription.put("ncs",ncs);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/pom.xml
File asterixdb/pom.xml:

Line 71:     <jacoco.version>0.7.6.201602180812</jacoco.version>
add jackson here?


Line 809:       </dependency>
add jackson here?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/algebricks/algebricks-runtime/pom.xml
File hyracks-fullstack/algebricks/algebricks-runtime/pom.xml:

Line 78:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/algebricks/algebricks-tests/pom.xml
File hyracks-fullstack/algebricks/algebricks-tests/pom.xml:

Line 164:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-api/pom.xml
File hyracks-fullstack/hyracks/hyracks-api/pom.xml:

Line 96:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/ActivityCluster.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/ActivityCluster.java:

Line 208:                 jan.put("inputs", jInputs);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 220:                 jan.put("outputs", jOutputs);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 229:                 jan.put("depends-on", jDeps);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 233:         jac.put("activities", jans);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java:

Line 379:                     pcObject.put("location", pleObject);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 382:                     op.put("partition-constraints", pcObject);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-client/pom.xml
File hyracks-fullstack/hyracks/hyracks-client/pom.xml:

Line 112:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/pom.xml:

Line 117:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java:

Line 259:             acJSON.put("activities", activitiesJSON);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 265:             acJSON.put("dependencies", dependenciesJSON);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 289:                     entry.put("input-partition-counts", inPartCountsJSON);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 298:                     entry.put("output-partition-counts", outPartCountsJSON);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 324:                 planJSON.put("activities", acTasks);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 335:                     c.put("tasks", tasksAry);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 341:                     c.put("produced-partitions", prodParts);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 347:                     c.put("required-partitions", reqdParts);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 379:                             attempt.put("task-attempts", taskAttempts);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 384:                     c.put("attempts", attempts);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 388:                 planJSON.put("task-clusters", tClusters);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 390:                 acJSON.put("plan", planJSON);
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java:

Line 740:         jobLogObject.put("activity-cluster-graph", acg.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 741:         jobLogObject.put("job-run", run.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobCleanupWork.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobCleanupWork.java:

Line 129:         jobLogObject.put("activity-cluster-graph", acg.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


Line 130:         jobLogObject.put("job-run", run.toJSON());
Replace "put" with "set"? "put" is deprecated (for JsonNode),


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml:

Line 73:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
File hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml:

Line 91:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/pom.xml:

Line 153:       <version>2.8.1</version>
Shared version?


https://asterix-gerrit.ics.uci.edu/#/c/1392/13/hyracks-fullstack/hyracks/hyracks-server/pom.xml
File hyracks-fullstack/hyracks/hyracks-server/pom.xml:

Line 184:       <version>2.8.1</version>
Shared version?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1392
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c5400fd134ae75d43385255af7794e968b1c7e
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message