asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Use a file to store the map from error codes to error messages.
Date Tue, 03 Jan 2017 17:44:44 GMT
Yingyi Bu has posted comments on this change.

Change subject: Use a file to store the map from error codes to error messages.
......................................................................


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1410/4/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

Line 33: 3,1003 = Type incompatibility: function %1$s gets incompatible input values: %2$s
and %3$s
> Should we consistently avoid the spaces around the "="?
This is intentional,  for testing whether having spaces still work.


https://asterix-gerrit.ics.uci.edu/#/c/1410/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/InvalidOperationException.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/InvalidOperationException.java:

Line 26: public class InvalidOperationException extends HyracksDataException {
> It seems to me that this is a little too much as we are creating a new exce
Done


https://asterix-gerrit.ics.uci.edu/#/c/1410/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ProcessTupleException.java
File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ProcessTupleException.java:

Line 1: /*
> Same comments as for InvalidOperationException apply.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1410
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I344903a9961469b62a951a9095514bf671ff11ee
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message