Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Wed, 21 Dec 2016 13:08:07 -0800
From: "Till Westmann (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
To: Yingyi Bu <buyingyi@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Michael Blow <mblow@apache.org>, Steven Jacobs <sjaco002@ucr.edu>
Reply-To: tillw@apache.org
Subject: Change in asterixdb[master]: Supports flexible degree of parallelism.
In-Reply-To: <gerrit.1482190979152.If70faf52bed995c7098cc343f2fabd1b6c8d96e7@asterix-gerrit.ics.uci.edu>
References: <gerrit.1482190979152.If70faf52bed995c7098cc343f2fabd1b6c8d96e7@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20161221210807.8765D240723@unhygienix.ics.uci.edu>
archived-at: Wed, 21 Dec 2016 21:08:42 -0000

Till Westmann has posted comments on this change.

Change subject: Supports flexible degree of parallelism.
......................................................................


Patch Set 11:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1398/11//COMMIT_MSG
Commit Message:

Line 9: Detailed list of changes include:
Really appreciate this list!


https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 358:     // Computes the location constraints based on user-configured parallism parameter.
s/parallism/parallelism/


Line 366:             int parallelism = parallelismHint <= 0 ? -2 * ncMap.size() : parallelismHint;
What's the meaning of -2 here?


https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

Line 169: import org.apache.asterix.translator.TypeTranslator;
There's something funny going on with the imports ... they are different for me ..


https://asterix-gerrit.ics.uci.edu/#/c/1398/11/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java
File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RepeatedTest.java:

Line 91:         return testArgs;
If there's another patchset we could just replace this method body with

    return LangExecutionUtil.buildTestsInXml(TestCaseContext.DEFAULT_REPEATED_TESTSUITE_XML_NAME);

and remove the static import - but don't create a new patchset for this.


https://asterix-gerrit.ics.uci.edu/#/c/1398/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NestedLoopJoinPOperator.java:

Line 130:                         null);
It seems that there could be some utility method the could determine the StructuralPropertiesVector based on the inputs, the context, and the classes of the partitioning properties that would make this more intuitive.
But I'm not sure (and I'm not sure where to put it) - it's just a thought.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1398
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If70faf52bed995c7098cc343f2fabd1b6c8d96e7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes