asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1720 - Generate License Files
Date Thu, 29 Dec 2016 01:59:16 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1720 - Generate License Files
......................................................................


Patch Set 9:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1402/9//COMMIT_MSG
Commit Message:

Line 10: using Apache FreeMarker templates, formatting to desired LICENSE output
Indent as below? :)


https://asterix-gerrit.ics.uci.edu/#/c/1402/9/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java
File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/LicensedProjects.java:

Line 40:     public int compareTo(LicensedProjects o) {
> CRITICAL SonarQube violation:
Do we know, that we only need compareTo and not equals() and hashCode()?


https://asterix-gerrit.ics.uci.edu/#/c/1402/9/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java
File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/project/Project.java:

Line 122:     public int compareTo(Project o) {
> CRITICAL SonarQube violation:
Do we know, that we only need compareTo and not equals() and hashCode()?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1402
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0963a85cb2be47dbf6bfd8c7f6fec767ef32e7e2
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message