asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1720 - Generate License Files
Date Sat, 24 Dec 2016 00:20:04 GMT
Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1720 - Generate License Files
......................................................................


Patch Set 8:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1402/8/asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java
File asterixdb/asterix-maven-plugins/license-automation-plugin/src/main/java/org/apache/asterix/license/LicenseMojo.java:

Line 134:                 final LicenseSpec l2 = urlToLicenseMap.get(o2.getLeft());
999?


Line 151:             } catch (MalformedURLException e) {
It probably doesn't matter in this case, but is there some way to know the URL is valid without
a try/catch?


https://asterix-gerrit.ics.uci.edu/#/c/1402/8/asterixdb/src/main/licenses/content/opensource.org_licenses_bsd-license.php.txt
File asterixdb/src/main/licenses/content/opensource.org_licenses_bsd-license.php.txt:

Line 1: <OWNER> = Regents of the University of California
Whats with this license?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1402
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0963a85cb2be47dbf6bfd8c7f6fec767ef32e7e2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message