asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <>
Subject Change in asterixdb[master]: Change the API for writing and reading metadata pages
Date Tue, 20 Dec 2016 01:39:46 GMT
Till Westmann has posted comments on this change.

Change subject: Change the API for writing and reading metadata pages

Patch Set 6:

File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/

Line 73:         return -1L;
A named constant wasn't bad. Could we bring one back? (Not sure where the best place for it
would be ..)
File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/

Line 346:                     if (afp.getLSNByteOffset() >= 0L) {
Again, the named constant seems better.
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/

Line 29:     public void resetByTupleOffset(byte[] buf, int tupleStartOffset);
What is the benefit of this interface change?
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/

Line 37:     protected static final int PAGE_LSN_OFFSET = Constants.RESERVED_HEADER_SIZE;
I thought that LSNs were a Tx processing concept that shouldn't be needed/mentioned in Hyracks
anymore. Would it make sense to just use the header size here?
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/

Line 306:         put(frameFactory.createFrame(), key, value);
Do we actually allocate a new frame for every call?

Line 311:         get(createMetadataFrame(), key, value);
Do we actually allocate a new frame for every call?
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/

Line 69:         treeMetaManager.get(MARKER_LSN_KEY, pointable);
Why do we need a MARKER_LSN_KEY in Hyracks?
File hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/frames/

Line 38:     protected static final int PAGE_NSN_OFFSET = TreeIndexNSMFrame.RESERVED_HEADER_SIZE;
What is an NSN?

Line 44:     private static final double DOUEBLE_EPSILON = computeDoubleEpsilon();

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-HasComments: Yes

View raw message