asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Change the API for writing and reading metadata pages
Date Mon, 19 Dec 2016 21:22:14 GMT
Ian Maxon has posted comments on this change.

Change subject: Change the API for writing and reading metadata pages
......................................................................


Patch Set 5:

(8 comments)

Some questions, I still need to go over the get/put stuff in more detail though.

https://asterix-gerrit.ics.uci.edu/#/c/1396/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java:

Line 101:         ((IMetadataPageManager) treeIndex.getPageManager()).put(LSN_KEY, new MutableArrayValueReference(lsn));
Why's the cast necessary? Shouldn't we just change it in ITreeIndex?


Line 106:         ((IMetadataPageManager) treeIndex.getPageManager()).get(LSN_KEY, pointable);
Can we make the -1L a static final long with some sort of name?


https://asterix-gerrit.ics.uci.edu/#/c/1396/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java:

Line 394:         destTuple.setFieldCount(fieldCnt);
What's this about?


https://asterix-gerrit.ics.uci.edu/#/c/1396/5/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java
File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java:

Line 345:                     String componentId = LSMComponentProperties.getLSMComponentID(afp.getFilePath());
Again, why introduce magic numbers where static final variables were?


https://asterix-gerrit.ics.uci.edu/#/c/1396/5/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexFrame.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexFrame.java:

Line 34:     public static class Constants {
Why's this moved to here?


https://asterix-gerrit.ics.uci.edu/#/c/1396/5/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java:

Line 36:     protected static final int MAX_PAGE_OFFSET = ITreeIndexFrame.Constants.RESERVED_HEADER_SIZE;
It would be nice to still have the comments about the running length on each value.


Line 273:             int offset = getTupleStart(index);
Why 2?


https://asterix-gerrit.ics.uci.edu/#/c/1396/5/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/frames/LIFOMetadataFrameTest.java
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/frames/LIFOMetadataFrameTest.java:

Line 45:                 + testKey.getLength());
52?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1396
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message