asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <>
Subject Change in asterixdb[master]: Change the API for writing and reading metadata pages
Date Mon, 19 Dec 2016 21:22:14 GMT
Ian Maxon has posted comments on this change.

Change subject: Change the API for writing and reading metadata pages

Patch Set 5:


Some questions, I still need to go over the get/put stuff in more detail though.
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/

Line 101:         ((IMetadataPageManager) treeIndex.getPageManager()).put(LSN_KEY, new MutableArrayValueReference(lsn));
Why's the cast necessary? Shouldn't we just change it in ITreeIndex?

Line 106:         ((IMetadataPageManager) treeIndex.getPageManager()).get(LSN_KEY, pointable);
Can we make the -1L a static final long with some sort of name?
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/

Line 394:         destTuple.setFieldCount(fieldCnt);
What's this about?
File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/

Line 345:                     String componentId = LSMComponentProperties.getLSMComponentID(afp.getFilePath());
Again, why introduce magic numbers where static final variables were?
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/

Line 34:     public static class Constants {
Why's this moved to here?
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/

Line 36:     protected static final int MAX_PAGE_OFFSET = ITreeIndexFrame.Constants.RESERVED_HEADER_SIZE;
It would be nice to still have the comments about the running length on each value.

Line 273:             int offset = getTupleStart(index);
Why 2?
File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/test/java/org/apache/hyracks/storage/am/common/frames/

Line 45:                 + testKey.getLength());

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-HasComments: Yes

View raw message