asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Introduce CheckpointManager API
Date Fri, 16 Dec 2016 07:18:11 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Introduce CheckpointManager API
......................................................................


Patch Set 5:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1380/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Checkpoint.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Checkpoint.java:

Line 104:         result = prime * result + (int) (minMCTFirstLsn ^ (minMCTFirstLsn >>>
32));
> What's the 1231 & 1237 about?
This is an auto-generated hashCode method by Eclipse that uses all attributes in the class.
These two numbers are just prime numbers chosen by Eclipse.


https://asterix-gerrit.ics.uci.edu/#/c/1380/5/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java:

Line 128: 
> What's this about?
The capture method? It just captures a checkpoint the specified LSN
as follows 1) create checkpoint object. 2) persist it to disk. 3) run a cleanup to delete
old checkpoints.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1380
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36c00ca195b93bbe1e53f39bb4a3b5a344657f0d
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message