asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Introduce CheckpointManager API
Date Tue, 13 Dec 2016 01:36:59 GMT
Ian Maxon has posted comments on this change.

Change subject: Introduce CheckpointManager API
......................................................................


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:

Line 251:         if (!pendingFailbackCompletion) {
It's not a checkpoint, but it's checkpointy ;)


https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java:

Line 29:     private static final int LOCAL_STORAGE_VERSION = 1;
Why a separate version?


https://asterix-gerrit.ics.uci.edu/#/c/1380/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java:

Line 28: /**
s/demon/daemon


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1380
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36c00ca195b93bbe1e53f39bb4a3b5a344657f0d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message