asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <>
Subject Change in asterixdb-bad[master]: Updated to match code changes to asterix
Date Mon, 05 Dec 2016 05:36:04 GMT
Till Westmann has posted comments on this change.

Change subject: Updated to match code changes to asterix

Patch Set 15:


A first round of comments.
File .gitignore:

Line 3: asteri-opt-bom/target
Shouldn't those be covered by "target" below?

Line 12: *.hprof
Are these actually created by the build?
Commit Message:

Line 7: Updated to match code changes to asterix
Would be nice to have a better description here.
File asterix-bad/src/main/java/org/apache/asterix/bad/

Line 41: import org.json.JSONException;
We shouldn't use org.json anymore - the license is category X now.

Line 60:                     e.printStackTrace();
Could we at least log this with a log4j logger?

Line 113:         //TODO: Allow Repetitive Channels to use YMD durations  

Line 125: 
empty line

Line 137: 
empty line

Line 163:                 } catch (Exception e) {
Remove the try-catch?

Line 167:                 throw new Exception();
Give an error message?

Line 186:                     System.out.println(response.toString());
Log to a logger?

Line 189:                 throw new Exception();
Give an error message?

Line 193:   "Broker connection failed to write");
Pass the exception it?
File asterix-bad/src/main/java/org/apache/asterix/bad/metadata/

Line 96: 
empty lines?
File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/

Line 65:         } catch (Exception e) {
Can't we just throw HyracksDataException from the beginning?
File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/

Line 62: 
File asterix-bad/src/main/resources/lang-extension/lang.txt:

Line 59:       	      | "broker" pairId = QualifiedName() ifExists = IfExists()	
File asterix-bad/src/test/resources/runtimets/queries/channel/drop_channel_check_metadata/drop_channel_check_metadata.3.query.aql:

Line 3: for $result in dataset Metadata.Channel 
File asterix-opt-bom/pom.xml:

Line 20:     xsi:schemaLocation="">
Formatting - WS and indentation.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a
Gerrit-PatchSet: 15
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <>
Gerrit-Reviewer: Ian Maxon <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Steven Jacobs <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message