asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xikui Wang (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add record reader and parser for CAP messages
Date Fri, 02 Dec 2016 09:12:11 GMT
Xikui Wang has posted comments on this change.

Change subject: Add record reader and parser for CAP messages
......................................................................


Patch Set 13:

(2 comments)

Hi Till&Abdullah,

Thanks for your comments. I updated this patch accordingly. Also I find one bug in processing
nested list when addressing Till's comments, so I ended up refactoring the CAPMessageParser...
Sorry about the mess in the previous one. Thanks! :) 

Best,
Xikui

https://asterix-gerrit.ics.uci.edu/#/c/1269/13/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/CAPMessageParser.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/CAPMessageParser.java:

Line 71:     public final int SMART_BUILDER_STATE_VALUE = 3;
> MAJOR SonarQube violation:
will fix this in next submit


https://asterix-gerrit.ics.uci.edu/#/c/1269/13/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:

Line 240:             } catch (InterruptedException x) {
> CRITICAL SonarQube violation:
@Till, If I understand correctly, the system watcher here is used to monitor a directory waiting
for new files coming in. The interruption happens when we disconnect feed or shutdown the
system.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1269
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36101a0761973a9edb96b42d3dcc117661301da
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Xikui Wang <xkkwww@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message