asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enable Replication Tests on Multi-NC Setup
Date Thu, 01 Dec 2016 07:41:44 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Enable Replication Tests on Multi-NC Setup
......................................................................


Patch Set 2:

(2 comments)

two small comments. 
We are heading in the direction where we refer to local files in an NC by the FileReference
and we call getFile() when we need to read the actual data inside the file.
seems like there is another good chance to do the same here and reduce the use of the absolute
file paths.

https://asterix-gerrit.ics.uci.edu/#/c/1364/2/asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/ConfigureCommand.java
File asterixdb/asterix-installer/src/main/java/org/apache/asterix/installer/command/ConfigureCommand.java:

Line 71:         if (!Files.exists(Paths.get(localClusterPath))) {
when do we hit this case?


https://asterix-gerrit.ics.uci.edu/#/c/1364/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

Line 364: 
Let's use the FileReference object instead of getting the absolute Path since this is the
direction we're heading?

The path inside the FileReference will be the path inside the IO device.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1364
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I542b212e04469e2701690f464f821a5189b97f12
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message