Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C7012200BB3 for ; Wed, 2 Nov 2016 17:43:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C5991160AFB; Wed, 2 Nov 2016 16:43:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 17DEC160AF0 for ; Wed, 2 Nov 2016 17:43:16 +0100 (CET) Received: (qmail 3336 invoked by uid 500); 2 Nov 2016 16:43:15 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 3323 invoked by uid 99); 2 Nov 2016 16:43:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 16:43:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 636F9180481 for ; Wed, 2 Nov 2016 16:43:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5dMFMQ_mPZno for ; Wed, 2 Nov 2016 16:43:13 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BB57C5FC2E for ; Wed, 2 Nov 2016 16:43:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 0658A2420B0; Wed, 2 Nov 2016 09:43:12 -0700 (PDT) Date: Wed, 2 Nov 2016 09:43:12 -0700 From: "Ian Maxon (Code Review)" CC: Jenkins , Michael Blow Reply-To: imaxon@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Fix for ASTERIXDB-1725 X-Gerrit-Change-Id: I9f21e96ab045d331e4fc1c77b5c73b975e6260fa X-Gerrit-ChangeURL: X-Gerrit-Commit: 46b564a89bbd5177222f3a99863fae1dc8ac3ec0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20161102164312.0658A2420B0@unhygienix.ics.uci.edu> archived-at: Wed, 02 Nov 2016 16:43:18 -0000 Ian Maxon has posted comments on this change. Change subject: Fix for ASTERIXDB-1725 ...................................................................... Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1331/1/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java: Line 130: buf.putInt(ROOT_PAGE_NUMBER,0); > /,0/, 0/ Oh, sonar doesn't check this? https://asterix-gerrit.ics.uci.edu/#/c/1331/1/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java: Line 473: return ((long) metadataPageNum * (bufferCache.getPageSize() + BufferCache.RESERVED_HEADER_BYTES)) > Should we push getPageSizeWithHeader() to IBufferCache and reference it her That was what I wanted to do but I wasn't sure if there was a reason it was not exposed. However if the author of that method is puzzled about why I didn't do that, it may be a bad sign for my reasoning ;) -- To view, visit https://asterix-gerrit.ics.uci.edu/1331 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f21e96ab045d331e4fc1c77b5c73b975e6260fa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: Yes