asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Parameter documentation for nc service installtion.
Date Sat, 26 Nov 2016 23:25:32 GMT
Yingyi Bu has posted comments on this change.

Change subject: Parameter documentation for nc service installtion.
......................................................................


Patch Set 3:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1355/3/asterixdb/asterix-doc/src/site/markdown/ncservice.md
File asterixdb/asterix-doc/src/site/markdown/ncservice.md:

Line 138: | command | The command for the slave process | cbasnc |
> The default value seems wrong - we either need to fix the docs or the code.
Done


Line 142: | metadata.port | The metadata communication port on the metadata node. This parameter
should only present in the section of the metadata NC | 0 |
> s/present/be present/?
Done


Line 159: | txn.lock.timeout.waitthreshold | Time out (in milliseconds) of waiting a lock
| 60000 |
> s/of waiting a lock/of waiting for a lock/
Done


Line 163: | txn.log.checkpoint.lsnthreshold | The checkpoint threshold (in terms of LSN number)
for transection logs | 67108864 |
> I'm not sure I understand.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mblow@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message